Add interface names into NSM metrics #1572

NikitaSkrynnik · 2023-12-29T12:05:41Z

Issue

networkservicemesh/sdk-vpp#768

Original PR

#1560

How Has This Been Tested?

Added unit testing to cover
Tested manually
Tested by integration testing
Have not tested

Types of changes

codecov · 2024-01-10T04:20:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@d109337). Click here to learn what that means.

❗ Current head 2a94596 differs from pull request most recent head 0484c4e. Consider uploading reports for the commit 0484c4e to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1572   +/-   ##
=======================================
  Coverage        ?   67.30%           
=======================================
  Files           ?      261           
  Lines           ?    12382           
  Branches        ?        0           
=======================================
  Hits            ?     8334           
  Misses          ?     3525           
  Partials        ?      523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/networkservice/common/mechanisms/client.go

VitalyGushin · 2024-01-10T12:33:23Z

LGTM

pkg/networkservice/chains/endpoint/combine_test.go

Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

This reverts commit b1509d1. Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

glazychev-art · 2024-01-16T06:17:03Z

pkg/networkservice/chains/endpoint/combine_test.go

 		begin.NewServer(),
 		metadata.NewServer(),
 		monitor.NewServer(ctx, &e.MonitorConnectionServer),
+		mechanisms.NewServer(map[string]networkservice.NetworkServiceServer{
+			mechanism: updatepath.NewServer(name),


Have you tried using null.NewServer() here and leaving updatePath at the previous place?

Yes, I have. It didn't work

…k@main PR link: networkservicemesh/sdk#1572 Commit: d76b20e Author: Nikita Skrynnik Date: 2024-01-16 20:26:06 +1100 Message: - Add interface names into NSM metrics (#1572) * Task:768 Add interface names into NSM metrics Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * remove withMetrics flag from client and server Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix combine tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix golang linter Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix more tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rerun CI Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply review comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * Revert "fix combine tests" This reverts commit b1509d126cd2a890d4cfd3eb6338a05fb37076ac. Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests different way Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> --------- Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

denis-tingaikin assigned VitalyGushin Jan 9, 2024

NikitaSkrynnik force-pushed the task/768_add_interface_names branch 4 times, most recently from b27242a to 0ddb1d7 Compare January 10, 2024 04:52

NikitaSkrynnik marked this pull request as ready for review January 10, 2024 04:58

VitalyGushin reviewed Jan 10, 2024

View reviewed changes

pkg/networkservice/common/mechanisms/client.go Outdated Show resolved Hide resolved

VitalyGushin removed their assignment Jan 10, 2024

VitalyGushin approved these changes Jan 10, 2024

View reviewed changes

denis-tingaikin reviewed Jan 11, 2024

View reviewed changes

pkg/networkservice/chains/endpoint/combine_test.go Outdated Show resolved Hide resolved

Alexander Peretyatko and others added 9 commits January 15, 2024 19:14

Task:768 Add interface names into NSM metrics

63b1199

Signed-off-by: Alexander Peretyatko <alexander.peretyatko@xored.com> Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

remove withMetrics flag from client and server

0e9c62f

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

fix combine tests

4dd6ec4

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

fix golang linter

14a25e5

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

fix more tests

ca0b5b4

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

rerun CI

5f3f7fc

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

rerun CI

e9336aa

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

apply review comments

18b8b70

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

Revert "fix combine tests"

e5fc986

This reverts commit b1509d1. Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

NikitaSkrynnik force-pushed the task/768_add_interface_names branch from 5ab568d to 2a94596 Compare January 15, 2024 08:14

fix tests different way

0484c4e

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

NikitaSkrynnik force-pushed the task/768_add_interface_names branch from 2a94596 to 0484c4e Compare January 15, 2024 08:58

glazychev-art reviewed Jan 16, 2024

View reviewed changes

denis-tingaikin approved these changes Jan 16, 2024

View reviewed changes

denis-tingaikin merged commit d76b20e into networkservicemesh:main Jan 16, 2024
15 checks passed

nsmbot mentioned this pull request Jan 16, 2024

Update from update/networkservicemesh/sdk networkservicemesh/cmd-csi-driver#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add interface names into NSM metrics #1572

Add interface names into NSM metrics #1572

NikitaSkrynnik commented Dec 29, 2023 •

edited

Loading

codecov bot commented Jan 10, 2024 •

edited

Loading

VitalyGushin commented Jan 10, 2024

glazychev-art Jan 16, 2024

NikitaSkrynnik Jan 16, 2024

Add interface names into NSM metrics #1572

Add interface names into NSM metrics #1572

Conversation

NikitaSkrynnik commented Dec 29, 2023 • edited Loading

Issue

Original PR

How Has This Been Tested?

Types of changes

codecov bot commented Jan 10, 2024 • edited Loading

Codecov Report

VitalyGushin commented Jan 10, 2024

glazychev-art Jan 16, 2024

Choose a reason for hiding this comment

NikitaSkrynnik Jan 16, 2024

Choose a reason for hiding this comment

NikitaSkrynnik commented Dec 29, 2023 •

edited

Loading

codecov bot commented Jan 10, 2024 •

edited

Loading